Announcement

Do not use the forums to submit bug reports, feature requests or patches, submit a New Ticket instead.

#1 2007-01-24 08:02:54

flemming
New member
Registered: 2007-01-24
Posts: 4

EFM extended file manager - iframe height problem!

Hi Guys!

I have the EFM installed and almost working fine (Fine in firefox anyway!) but in IE 6 and 7, the iframe which contains the thumbnails or list view is just a thin slit.

Anyone know what i've done wrong?

many thanks,

Flemming

Offline

#2 2007-01-24 12:40:32

jelmer
Xinha Community Member
Registered: 2007-01-11
Posts: 11

Re: EFM extended file manager - iframe height problem!

I got the same problem...

i have changed something in manager.js at line 532:

old:
document.getElementById('imgManager').style.height = win.y - 150 - offsetForInputs + 'px';

new:
document.getElementById('imgManager').style.height = int (win.y - 150 - offsetForInputs) + 'px';

and it works now ok with me...

does it work for you?

Last edited by jelmer (2007-01-25 06:54:23)

Offline


Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

#3 2007-01-24 18:27:30

ray
Xinha Administrator
From: Germany
Registered: 2005-03-23
Posts: 521
Website

Re: EFM extended file manager - iframe height problem!

see http://xinha.python-hosting.com/ticket/921

Last edited by ray (2007-01-25 08:36:10)

Offline

#4 2007-01-25 08:52:48

volhovec
Xinha Community Member
Registered: 2007-01-18
Posts: 13

Re: EFM extended file manager - iframe height problem!

were is that file manager.js ???
i couldn't find this string document.getElementById('imgManager').style.height = win.y - 150 - offsetForInputs + 'px';
anywhere

Offline


Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

#5 2007-01-25 09:12:38

ray
Xinha Administrator
From: Germany
Registered: 2005-03-23
Posts: 521
Website

Re: EFM extended file manager - iframe height problem!

plugins/ExtendedFileManager/assets/manager.js

You can download a (hopefully ) fixed version from here http://xinha.python-hosting.com/file/tr … format=txt
I could not reproduce the error and therefore not test the fix

Offline

#6 2007-01-25 09:56:49

volhovec
Xinha Community Member
Registered: 2007-01-18
Posts: 13

Re: EFM extended file manager - iframe height problem!

ray, this error not present in simly form, but i reproduced that in Smarty dynamic template form
in first time i fixed this by PHP script in manager.php, but this method is more suitable...

in your js file - parseInt(win.y - 150 - offsetForInputs) - it's not work... but int(win.y - 150 - offsetForInputs) - worked propertly

Offline

#7 2007-01-25 11:07:07

ray
Xinha Administrator
From: Germany
Registered: 2005-03-23
Posts: 521
Website

Re: EFM extended file manager - iframe height problem!

there is no function called int. What you do by this is creating  a javascript error and stop executing the resize function that originally should care for a resizing of the iframe relative to the window size.

If it keeps not to work, you better disable the calling of the function itself, which is in the last line of the file

//addEvent(window, 'resize', resize);

I'd like to have a look at a page where this error occurs, because, like I said, I could not reproduce it in my test browsers

Offline


Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

#8 2007-01-26 04:24:32

volhovec
Xinha Community Member
Registered: 2007-01-18
Posts: 13

Re: EFM extended file manager - iframe height problem!

If you whant to see this error
http://somestuff.trusted-systems.ru/bug.php

Offline

#9 2007-01-26 09:21:29

ray
Xinha Administrator
From: Germany
Registered: 2005-03-23
Posts: 521
Website

Re: EFM extended file manager - iframe height problem!

Thank you for the example, that helped!
I have located the problem and I think how to fix it.
1. Open XinhaCore.js
2. locate the function Xinha.viewportSize
3. replace it by this version

Xinha.viewportSize = function(scope)
{
  scope = (scope) ? scope : window;
  var x,y;
  if (scope.innerHeight) // all except Explorer
  {
    x = scope.innerWidth;
    y = scope.innerHeight;
  }
  else if (scope.document.documentElement && scope.document.documentElement.clientHeight)
  // Explorer 6 Strict Mode
  {
    x = scope.document.documentElement.clientWidth;
    y = scope.document.documentElement.clientHeight;
  }
  else if (scope.document.body) // other Explorers
  {
    x = scope.document.body.clientWidth;
    y = scope.document.body.clientHeight;
  }
  return {'x':x,'y':y};
};

Please report, if this solves the problem for you.
I have also commited this to the trunk.

Offline


Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

Deprecated: preg_replace(): The /e modifier is deprecated, use preg_replace_callback instead in /home/xinha/public_html/r.f/include/parser.php on line 774

#10 2007-01-26 10:49:11

volhovec
Xinha Community Member
Registered: 2007-01-18
Posts: 13

Re: EFM extended file manager - iframe height problem!

I was replace that function...
All work propertly, you see http://somestuff.trusted-systems.ru/bug.php

Offline

#11 2007-01-26 10:56:50

ray
Xinha Administrator
From: Germany
Registered: 2005-03-23
Posts: 521
Website

Re: EFM extended file manager - iframe height problem!

I'm glad to hear that! smile

Remember: If somethings not working right,  give a link, so we can have a look and quickly sort this out. This helps you, us, and everybody.
Also you should create a ticket.

Offline

Board footer

Powered by FluxBB